Normalize `date` and `time` value annotations
alancai98 opened this issue · comments
I noticed that some TIME
values in the test data use an annotated struct:
e.g.:
While some other TIME
values use an annotated string:
e.g.
partiql-tests/partiql-tests-data/eval/spec-tests.ion
Lines 755 to 758 in e24d8ef
The partiql-tests
spec proposal defines using the annotated string form: https://github.com/partiql/partiql-tests/blob/e24d8ef837303e675bc7c29b8a41f3cc81d6b96e/docs/partiql-tests-schema-proposal.md#modeling-partiql-types-in-ion.
These should likely be normalized to the same thing.
TODO:
- Also sort out the modeling of other time/timestamp types that use timezone
date
is also modeled using a timestamp in some tests
The spec proposal uses an annotated string: https://github.com/partiql/partiql-tests/blob/e24d8ef837303e675bc7c29b8a41f3cc81d6b96e/docs/partiql-tests-schema-proposal.md#modeling-partiql-types-in-ion.
Also need to normalize how PartiQL timestamps are to be represented in Ion (could be the same as Ion?)