Menu entry for removing wallets
btmr opened this issue · comments
Is your feature request related to a problem? Please describe.
Being able to simply add new wallets but not having an option to remove them is a bit confusing.
It makes me feel like I don't have total control over my wallet setup.
Describe the solution you'd like
Ideally, I'd see a "Remove wallet" entry in the wallet drop-down menu, right below the entry "New wallet".
This would be concise with the the UI.
Describe alternatives you've considered
I currently remove wallets by deleting the corresponding wallet-files in the file system but users should not be expected to dig that deep.
Personally, I'm always looking for a "right-click"-context menu for these kind of things but this wouldn't be in line with the rest of the UI.
Additional context
I am pretty sure this has been discussed already at some point, at least within the community. I feel it's a fundamental thing, so I wanted to bring it up again.
Yep, this is something that has been discussed, and as you pointed out, it is something that is missing from the application.
Some background info on why it was omitted for the v3.0 release (for future reference and all):
The particl-market service currently manages its own wallets (or as it refers to them: "identities"). In order to provide various functionality (ensure that it receives smsg destined for specific identity addresses, for example), it also stores the relevant address and some other details for each wallet it manages. Which means, when restoring a marketplace, you'll also need to restore the specific set of wallets it was managing at the time. I believe there's actually a single wallet that needs to be backed up, but regardless, this requires a proper backup and restore process for the particl-market service (which we'lll look at at some point going forward).
By itself, thats not really important. However, consider that the wallet module/app and the market module/app in the application are independent, and don't really know about each other. Which means, if providing for the deleting of a wallet in the wallet app, its possible for the user to delete their market related wallets inadvertently... without any warning from the application because there's no usage meaning associated with each wallet: how does the application know what is the usage for the wallet... all it know is that a deletion request is being made so it actions it accordingly.
Unfortunately, such an action results in breaking your marketplace. And without the ability for 'automated' backup and restores of the marketplace at the moment (and with a really finicky manual way to restore a marketplace from a backup), this puts the user in a very bad situation if it happens.
So, what this entails:
- separate wallets into specific groupings,
- ensure that any module/app managing their own wallets keep their wallets separate and in a different grouping
- apps managing wallets can then provide deletion options for those wallets accordingly.
There are means to do this... which builds on from other changes that are necessary or should be done. So yes, this is in the pipeline, just not something we were able to provide with this release.
This is actually a duplicate of #1733
I'll update that issue with the above comment.