parse-community / parse-server-s3-adapter

AWS S3 file storage adapter for Parse Server

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Tests are failing

acinader opened this issue · comments

The tests are failing since 7/27/18. (I still don't know why Travis stopped emailing when builds break :().

I suspect that the problem is because wherever the tests are saving files to and with whatever credentials they are using is no longer valid.

The test that is failing is included from another repo: https://github.com/parse-community/parse-server-conformance-tests/blob/master/specs/files.js

The location of the files and the credentials being used are encrypted in the .travis file.

I use this adapter. It is simple. Almost all of the tortured logic is option handling which is well covered.

I do not want to: setup a bucket for tests, set its permissions, test it locally without my own credentials being involved, encode it, deploy and test the deployment.

So, unless someone else wants to take this one, i see two options:

  1. just leave it alone. the lodash security issue almost certainly cannot be exploited here (but that's a guess)

  2. rip out the conformance dependency and also remove the encrypted vars from travis.

  3. someone else steps up and gets the conformance/integration tests all straightened out.

My preference is #3 :). though I am not going to hold my breath...

So that leaves my preference as #2 which I could do in a few minutes today.

@davimacedo have a preference?

@acinader #3 would be better for sure but I suggest a #4 that is not as good as #3, but I think it is better than #2 :)

Take a look here pls:
#68