Project fails to build with Git submodule
danirabbit opened this issue · comments
Describe the bug
It looks like we're unable to build NaSC because it relies on a git submodule
To Reproduce
https://github.com/elementary/appcenter-reviews/pull/77/checks?check_run_id=3403685174
Expected behavior
Since Flatpak has a built-in concept of vendoring, it might be better to use modules in your Flatpak manifest instead.
We encountered a similar issue in another app and the developer decided to add a build option here: https://github.com/ryonakano/konbucase/pull/68/files
I can build it with this without problems. https://github.com/parnold-x/nasc/blob/master/.github/workflows/main.yml#L17
Otherwise, no time right now to fiddle more with this flatpack stuff.
It looks like the github builder doesn't have network access, so the cloning fails
Is there any chance this could get looked at? I'd love NaSC to be available again on the AppCenter