paritytech / substrate-api-sidecar

REST service that makes it easy to interact with blockchain nodes built using Substrate's FRAME framework.

Home Page:https://paritytech.github.io/substrate-api-sidecar/dist/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

there is no migration path for noMeta migration

xlc opened this issue · comments

When noMeta is used, it will complain and ask for migration. But migrate to what?

This is old legacy code from Pre V14 metadata. It was replaced with the metadata query param. Its long overdue for completely removing noMeta. Thanks for bringing this up, as its been lost in the queue for a while. I'll get this in tomorrow to finally finish this.

The expected behavior will be: metadata query param takes in two values scale or json for the format of the metadata, and if the query param is not inputted the field wont be there.

The controller code can be seen here.

The migration on this was sloppy looking over the previous code being that if you wanted no metadata in the response you still have to input the noMeta query param. This should be completely solved with the above PR. Thanks for bringing this up.