why do we need to do a manual bump in pallet-salary?
xlc opened this issue · comments
why we need someone to call bump to bump the cycle instead of schedule it in scheduler?
IDK, we could also just put it into on_initialize
.
Add up the RegistrationPeriod
and PayoutPeriod
in the on_initialize
hook and when this passes from the current cycle it will call bump
on the next block? Doesn't seem like there are edge cases where doing this might fail?
We don't need an extrinsic to manually call bump
then? this can be changed into an helper function but retain the WeightInfo
for bump
.
You can call the bump automatically in on_idle
or on_poll
. Yea weight still needs to be accounted for.
Just start a merge request so we can give feedback on that.
We should use a task
for this or not?