paragonie / sodium_compat

Pure PHP polyfill for ext/sodium

Home Page:https://paragonie.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

SODIUM_CRYPTO_KX_BYTES vs SODIUM_CRYPTO_KX_SEEDBYTES

jrfnl opened this issue · comments

Just came across a potential inconsistency between this library and the PHP native implementation.

In the PHP native implementation, there is a constant called SODIUM_CRYPTO_KX_SEEDBYTES.
https://github.com/php/php-src/blob/397d40cdd7830add08e382c2e8f187b37b55f180/ext/sodium/libsodium.c#L507

I cannot find that constant in this library, but I can find the SODIUM_CRYPTO_KX_BYTES constant which does not seem to exist in PHP itself.

const CRYPTO_KX_BYTES = ParagonIE_Sodium_Compat::CRYPTO_KX_BYTES;

Just thought I'd ask about it.

commented

Mere oversight. I'll fix this ASAP.

@paragonie-scott Thanks. Glad I reported it in that case ;-)

commented

Fixed and released in v1.6.1.

Thank you!