Giters

palantir / witchcraft-go-server

A highly opinionated Go embedded application server for RESTy APIs

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Reduce default trace rate to 1%

asanderson15 opened this issue · comments

commented

What happened?

Currently, the default trace rate for the tracer on the main server context is 100%. This is rarely the right tracing rate, and accidentally using it can have a significant fan out effect downstream.

What did you want to happen?

We should reduce the default trace rate to 0.01 (1%), which is a reasonable default for most services. We could do this either as a default in the Install config yaml annotations or by changing the fallback sampler to one with 1% sample rate here.