palantir / godel

Go tool for formatting, checking, building, distributing and publishing projects

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

godel verify with --parallel is slower than running checks serially

k-simons opened this issue · comments

On our team we have started migrating and encouraging setting up godel CI integration to use:
./godelw verify --skip-test --skip-check && ./godelw test && ./godelw check --parallel=false instead of just running ./godelw verify.

This is because the parallelism appears to be oversubscribed and running these tests serially is actually significantly faster (~40% from what we have seen) the just running ./godelw verify. Ideally we could fix ./godelw verify to be correctly more performant than running the tasks serially and stop bifurcating CI configuration.

@k-simons, I have some cycles to take a look at this now. When you get a chance, can you point me to some example projects where you observed this difference so that I can dig in?

I think this behavior may depend on the codebase/environment, as when I did some quick testing on the godel codebase on my laptop, running checks in parallel completed faster than running them serially.