MSVC build not working
citron0xa9 opened this issue · comments
Erik Griese commented
Hey,
I tried building a project together with this library using Visual Studio 2017. There were 2 small things that needed to be adjusted (see https://github.com/citron0xa9/sigslot on branch fix_msvc_build
).
Can I just create a PR with my changes?
Pierre-Antoine Lacaze commented
Thank you for spotting this.
Your changes look good, you can go ahead an create a PR, I will merge it right away.
Erik Griese commented
Ok, thanks alot.
Pierre-Antoine Lacaze commented
Merged, thank you.