Generated Markdown is not markdown spec compatible
niderhoff opened this issue · comments
The generated markdown is not compatible with the markdownlint default settings (see here).
Maybe spacing after headings etc. should be configurable?
I know I can change my markdownlint settings, but it should really be the other way round I think and a lot of people might be using markdownlint anyway so we should give an option to make vscode journal compatible.
Solutions I could suggest:
A. make spacing after headings configurable
B. make a setting ("fix markdown automatically") that triggers the "fix all all violations in documents" (markdownlint.fixAll) of markdownlint if markdownlint is installed
Hello
does your "journal.tpl-entry":
match the default one
"journal.tpl-entry":# ${weekday}, ${localDate}\n\n## Tasks\n\n## Notes\n\nIt seem your config lack the "\n\n" after ${localDate} and Tasks and note note.
You must edit the vscode settings.json directly.
I changed it manually at some point and added the \n\n, so I cannot answer this question anymore. I will close this issue until somebody else has this problem.
Hello,
I just installed vscode journal on a different PC and the same thing happened. Note that I have NOT set ANY options whatsoever. This is default behaviour after install.
Note that there is no "journal.tpl-entry" in my settings.
{
"workbench.iconTheme": "vscode-icons",
"workbench.colorTheme": "One Dark Pro",
"terminal.integrated.shell.windows": "cmd.exe",
"window.zoomLevel": 0,
"editor.fontSize": 13,
"journal.base": "C:/Users/Nicolas/Documents/Journal",
"editor.tokenColorCustomizations": {
"textMateRules": [
{
"scope": "text.html.markdown.journal.task.open.bullet",
"settings": {
"foreground": "#FFFF00"
}
},
{
"scope": "text.html.markdown.journal.task.open.marker",
"settings": {
"foreground": "#FFFF00"
}
},
{
"scope": "text.html.markdown.journal.task.open.keyword",
"settings": {
"fontStyle": "italic"
}
},
{
"scope": "text.html.markdown.journal.task.open.text",
"settings": {}
},
{
"scope": "text.html.markdown.journal.task.completed.keyword",
"settings": {
"fontStyle": "italic"
}
},
{
"scope": "text.html.markdown.journal.task.completed.marker",
"settings": {
"foreground": "#AAAAAA"
}
},
{
"scope": "text.html.markdown.journal.task.completed.text",
"settings": {
"foreground": "#AAAAAA"
}
},
{
"scope": "text.html.markdown.journal.task.completed.bullet",
"settings": {
"foreground": "#FFFF00"
}
},
{
"scope": "text.html.markdown.journal.memo.keyword",
"settings": {
"fontStyle": "italic"
}
},
{
"scope": "text.html.markdown.journal.memo.bullet",
"settings": {
"foreground": "#FFFF00"
}
},
{
"scope": "text.html.markdown.journal.scope",
"settings": {
"foreground": "#FFFF00"
}
},
{
"scope": "text.html.markdown.journal.link.keyword",
"settings": {
"fontStyle": "italic"
}
},
{
"scope": "text.html.markdown.journal.link.bullet",
"settings": {
"foreground": "#FFFF00"
}
}
]
}
}Interestingly enough, if I add said settings-entry, I get the following suggestion default:
Taken your example, the issue seems to be where the memo is placed (directly after the header in this case), correct?
I am looking into it (hopefully in the weekend, quite busy atm)