Customization is overly complicated?
ensonic opened this issue · comments
bced1c6 turned some fixed values into variables, but since the colors are names by how the look and now what they are used for it is not easy to change the appearance as it seems.
This does not turn all the headings red :/
---
---
$conifer: #ff0000;
@import "{{ site.theme }}";
I ended up doing this, but I feel it is copying too much:
---
---
$pumpkin: #ffbe65;
$header: $pumpkin;
@import "{{ site.theme }}";
header {
border-bottom: 1px dashed $pumpkin;
}
header h1 {
color: $pumpkin;
}
Why did the patch added a bunch of commented // $header? Using the header var would let me skip the lines below the @import. If there is no good reason I can make a patch.
Hi @ensonic
I don't see any problem about it. It's fine have stylesheets modularized. I mean.
- This file to define colors by name:
https://github.com/pages-themes/hacker/blob/master/_sass/_default_colors.scss#L1:L27 - This other to assign a variables according to rules (see the top).
https://github.com/pages-themes/hacker/blob/master/_sass/jekyll-theme-hacker.scss#L1-L27
What do yo think?
This is now 6 month later ... My report was about 2 things:
- avoid the need to copy the header definitions
- imho the change should not leave commented out variable in the css, either it is needed of not. If the developer is unsure, if a bug and describe the concern.
I'm a simple user as you, using this theme giving advice about why is coded like this.
You don't need to comment anything.
As I said, leave the variable in colors and override it where you need. Even more, you can add another SSAS @import with your customs to don't lost defaults.
Moreover all github themes have the same structure.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.