packt-cli / Packt-Publishing-Free-Learning

Scripts that automatically claim and download free daily eBooks from https://www.packtpub.com/packt/offers/free-learning

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Packt Video

ranrinc opened this issue · comments

Its seems that Packt is now release video, can we download this too?

Yup, look at the latest (yesterday's) release.

I'm not sure wether you have already fixed it in the last couple hours, but yesterday I saw that when I included a video_tag in download_formats, the script first downloaded the code as "name_of_book_video.zip" and subsequently the videos folder with the same file name, thus making the video download fail

Is there away for me to download previous miss download?

You're right, there are conflicting file names. What I'd do is to skip downloading code files for videos as they are already in the package with the video. Does it seem reasonable to you or maybe you have another idea how to solve this problem?

@ranrinc Just remove code files and download and run download again with proposed fix installed (you can install it with pip install git+https://github.com/mjenczmyk/Packt-Publishing-Free-Learning.git@code --upgrade).

You can see the pull request here: #141.

@mjenczmyk alright.. I got this part and yes its now function correctly. Thanks

Should we merge? Is this the fix you would expect? What do you think @ranrinc @AlessioC?

@mjenczmyk I have no objection on merging this..

@mjenczmyk Another possibility could be to force the video and code download separately (therefore not together) but I don't know if is possible. Otherwise yes, I think that your fix is a good loophole. :)