Use gsettings default terminal, rather than always gnome-terminal

[jvonhoff]

I don't use gnome-terminal, but rather xfce4-terminal for my terminal. Gnome-terminal is not even installed.

When I try to set a bash command on an argos script, it never would fire. I figured out that I can call it with terminal=false to get it to run, but if terminal=true, it always tries to use gnome-terminal.

Could it, instead, look up the default terminal from gsettings? I've just changed gsettings using:
gsettings set org.gnome.desktop.default-applications.terminal exec xfce4-settings

but it appears the code in menuitem.js
argv = ["gnome-terminal", "--", "bash", "-c", activeLine.bash + "; exec ${SHELL:=bash}"];

will assume gnome-terminal, regardless.

[Fabio José Bohnenberger]

Same problem using gnome-console instead of gnome-terminal, used terminal=false as a workaround for that.

menuitem.js still uses fixed 'gnome-terminal' when terminal=true (default behavior).

I agree with @jvonhoff, different terminal emulators should be also considered (gnome-console, Alacritty, xterm, etc), or terminal should be default false