Application upgradation

Question

Application upgradation

cooligc opened this issue 6 years ago · comments

sitakant commented 6 years ago

Hi,

Is there any plan to upgrade spring boot to 2.0.1.RELEASE version ? If yes, when it will be available tentatively ?

Uri Naor commented 6 years ago

watching

Roberto Trunfio · Answer 1 · Fri Apr 20 2018 12:59:43 GMT+0800 (China Standard Time)

@cooligc not so soon I guess. I'm in rush with other projects, I don't have time to dedicate to the upgrade.

Indeed, this is an open source project. I'll accept contributions.

Roberto Trunfio · Answer 2 · Mon May 21 2018 03:59:03 GMT+0800 (China Standard Time)

I think that in the next days I may find the right mood for supporting Spring Boot 2.x in this project.

Roberto Trunfio · Answer 3 · Sun Jun 03 2018 14:06:46 GMT+0800 (China Standard Time)

I've started the upgrade. First thing I'm trying to accomplish, is to move the default services for REDIS persistence in a separate module. Since email persistence is not mandatory, I think that putting the default service there was a very bad idea.
I'm not sure how much time it will take the migration. There are dozens of broken tests and changes in SpringBoot2 that must be taken into account.

Mr E · Answer 4 · Fri Jul 27 2018 18:19:44 GMT+0800 (China Standard Time)

Just was wondering if there was any progress on this? Thanks.

Roberto Trunfio · Answer 5 · Tue Aug 07 2018 01:34:33 GMT+0800 (China Standard Time)

@limpep I have a lot of issues, and every time I find a new one I lose interest. But I'm working on it. Unfortunately, I don't have a release date at the moment.

Wanna help?

Mr E · Answer 6 · Tue Aug 07 2018 02:08:41 GMT+0800 (China Standard Time)

@robertotru I would love to help but I don't know where to begin plus I think I'll probably mess it up more than actually helping 😂

Roberto Trunfio · Answer 7 · Tue Aug 07 2018 15:44:48 GMT+0800 (China Standard Time)

I'm thinking about getting rid of the REDIS support (if one wants to have email persistence, can implement the service he prefers and also all the template engine but not Mustache.

This may speedup the upgrade.

Opinions?

cldsnchz · Answer 8 · Thu Aug 09 2018 08:47:10 GMT+0800 (China Standard Time)

I think it makes total sense to move the PersistenceService implementation (redis) to its own module.
If having that module is a pain to maintain then remove it, but it’s good thing to have a reference implementation.

Regarding the templates, I guess that having one reference implementation it’s enough, mostly because the integration is very similar among those engines.

It is nice to have those integrations done, but if having them means that you don't have time (or motivation) to maintain the core, in that case just get rid of them.

Roberto Trunfio · Answer 9 · Thu Aug 09 2018 14:45:19 GMT+0800 (China Standard Time)

Branch is https://github.com/ozimov/spring-boot-email-tools/tree/feature/move-to-spring-boot-2.0.x

Reza Ebrahimpour · Answer 10 · Tue Nov 27 2018 15:27:16 GMT+0800 (China Standard Time)

Please indicate the compatible Spring boot version in the home page of the repository. It can save time from other developers who want to integrate this library into Spring boot 2 projects. I didn't see anything about this issue and started to integrate this library into my project and while running I got the error and after searching for the reason I have found this open issue.

Roberto Trunfio · Answer 11 · Tue Nov 27 2018 15:38:57 GMT+0800 (China Standard Time)

@rezaep it is on the top banner, but maybe it should be also in the readme. We also do accept PRs :)