vhs-decode not decoding properly since recent Video 8 change
davidvankemenade opened this issue · comments
After this commit (happycube@0a8eb34) chroma seems to be broken. I previously decoded a Betamax sample which was perfectly fine. Today, I decoded the same capture file and the chroma was off and unstable over time.
Could it be that some NTSC parameters are applied to PAL?
Working well before last commit:
Chroma off after last commit:
Yeah I think I might have accidentally skipped the bits that make it not rotation on the chroma signal on PAL betamax (might have also broken u-matic.)
Should be sorted in 524b30e. Betamax still needs some work in general to look correct though.
Many thanks for sorting this out so quickly @oyvindln!
From what I've tried so far, Betamax looks pretty good. What still needs to be optimised?
The deemphasis filter is rather complicated just like for video8, right now the code is just using a simplified filter which doesn't get the balance quite right. One visible effect deemphasis being off is a smearing effect after sharp transitions. For PAL specifically there is also some performance stuff.