TraceMiddleware HttpRoutes support

Question

TraceMiddleware HttpRoutes support

user753 opened this issue 3 years ago · comments

user753 commented 3 years ago

I would be great if TraceMiddleware could work with Http instead of HttpApp, so it could be used with HttpRoutes.

Timothy Bess · Answer 1 · Thu May 06 2021 02:43:54 GMT+0800 (China Standard Time)

We just submitted a PR for supporting HttpRoutes:
#59

Timothy Bess · Answer 2 · Fri May 07 2021 01:31:45 GMT+0800 (China Standard Time)

Looks like this issue is addressed:
#59 (comment)

Tom · Answer 3 · Thu May 13 2021 17:44:41 GMT+0800 (China Standard Time)

Hi, sorry I didn't respond to this earlier - indeed hopefully my comment on #59 explains why we have to trace HttpApp - I've added a tiny bit of syntax & updated the docs to include a guide for tracing only some routes (which I think is the main reason to want to trace HttpRoutes) https://ovotech.github.io/natchez-extras/docs/natchez-http4s.html#tracing-only-some-routes