ovity / octotree

GitHub on steroids

Home Page:https://www.octotree.io/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

This extension breaks vimium's search

mijoharas opened this issue · comments

cross posting this here, not sure what's causing this, details on how to repro here

To quote my research from the Vimium bug:

...; on a fresh profile, running

window.find("p", false, true, true, false, true, false);window.getSelection();

gives different results depending on whether Octotree is enabled or not.

Since these are both natives and not overridden, something really screwy is going on here. Moreover, the selection after window.find is executed has type: "Caret", which is unexpected to say the least.

Good luck, I'm totally stumped. Seems like a Chromium bug, filing a report is probably the way to go.

No longer stumped; user-select: none here is causing all the grief. I would question whether it's really necessary to stop a user from selecting the text in the sidebar.

This still feels like a Chromium issue -- the window.find function probably shouldn't "get stuck" in a -webkit-user-select: none element -- but there's an easy fix so I doubt much will come of it.

Thanks for working on this. I already merged and published this update to Chrome store.

Thanks, fixes it for me 👍