Create_schema check for seeing if timestamp, component_id, and job_id are present is broken.
bschwal opened this issue · comments
I added a sampler and sos store for lustre_ods which does not have the job_id field because it is run on backend lustre servers. When I started the sampler a sos schema was made for lustre_ost with job_id as a field and it used as an index. On the first instance of the data trying to be stored the daemon dies because no job_id is present in the metric set (or at least not where it thinks it is).
I think there needs to be some checking in create_schema to see if the data is exists before executing a sos_schema_attr_add. Perhaps two code paths, one for if job_id is present and one if it is not (since timestamp and component_id should be in every schema).
Hi Ben,
We should look at addressing all of this with decomposition which doesn't have the built in assumptions like the one you just alluded to.
@bschwal did you check this out with decomposition?
@tom95858 I have not and I had to miss the decomposition dry-run so I still don't quite know how to do it.
@bschwal, i think this is still a bug, I'm just suggesting that you try decomposition to get going. There are man page(s) on decomposition and I can provide examples as well.
