overtrue / phplint

:bug: A tool that can speed up linting of php files by running several lint processes at once.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Better Symfony 7 support

sukhwinder33445 opened this issue · comments

New Issue

PHP Fatal error: Declaration of Overtrue\PHPLint\Console\Application::doRun(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output) must be compatible with Symfony\Component\Console\Application::doRun(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output): int in /home/runner/work/My_Module/vendor/overtrue/phplint/src/Console/Application.php on line 50

Diagnose

Installed with : Run composer require -n --no-progress overtrue/phplint
Version: (9.0.5)
PhpVersion: > 8.1

Related to PR #195. Allowing Symfony 7 components depencencies by Composer constraint was not enough to add full support to SF 7.
Especially because SF components signature has changed by adding return type hint.

This is the reason while it does not works on PHP 8.2 and 8.3 that install Symfony v7.0 component,
and while it works fine on PHP 8.1 that still install Symfony v6.4 components (signature compatible).

Tested locally, without to re-publish a new version by setting a dev environment such as :

{
    "repositories": [
        {
            "type": "path",
            "url": "../github/phplint"
        }
    ],
    "require": {
        "overtrue/phplint": "9.0.x-dev"
    },
    "minimum-stability": "dev"
}

Tests realized on PHP 8.1.26, 8.2.13, 8.3.0 without detecting any new issues.

Bugfix release 9.0.6 is on way !

v9.0.6 is now available