overtrue / phplint

:bug: A tool that can speed up linting of php files by running several lint processes at once.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

PHP 8.1 support and conflict with `brainmaestro/composer-git-hook`

llaville opened this issue · comments

I've noticed when trying to install a fresh copy (without composer.lock) of overtrue/phplint from branch 8.1, that we run in trouble; see following output :

devilbox@php-8.1.6 in /shared/backups/github/my-phplint $ composer update
Loading composer repositories with package information
Info from https://repo.packagist.org: #StandWithUkraine
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Root composer.json requires brainmaestro/composer-git-hooks ^2.8.5 -> satisfiable by brainmaestro/composer-git-hooks[v2.8.5].
    - brainmaestro/composer-git-hooks v2.8.5 requires symfony/console ^3.2 || ^4.0 || ^5.0 -> found symfony/console[v3.2.0-BETA1, ..., 3.4.x-dev, v4.0.0-BETA1, ..., 4.4.x-dev, v5.0.0-BETA1, ..., 5.4.x-dev] but it conflicts with your root composer.json require (^6.0).

Reason is that package brainmaestro/composer-git-hooks latest release 2.8.5 does not support yet symfony/console v6.

See origin of issue, from commit c5a9df9

Fix is easy, and PR will follow !

That should solve also issue #125

@overtrue PR #143 available for review/merge

@llaville Are you interested in maintaining this project? I can add you as a maintainer or transfer the project to you.

@overtrue Thanks for this offer ! I'm not sure to have enough time in future months, but I accept to be a co-maintainer.

@llaville Thank you very much.

This issue was fixed by commit 1f4d556 (merged), so this report may be closed