revlink warmup status sometimes is not saved correctly
DavidS-ovm opened this issue · comments
Sometimes I observe that multiple consecutive runs of the CLI do have to wait for revlink warmup, when a single one should suffice. Probably a bug in the finalisation code.
Further review showed that this is happening when the CLI stops waiting for warmup finishing and aborts it. This - correctly - causes warmup to not be marked as done in the database. We'll only be able to finish this as part of a larger effort to improve source lifecycle.
This is basically the way it's supposed to work. Ideally we'd be smarter about this but we will hold off on this until we have improved the way sources report and are tracked in general i.e.
- Revlink on a per-source basis
- Having the server understand which sources are available
...etc