uBlock Origin logger
stonecrusher opened this issue · comments
The new version of uBlock Origin got a reworked logger UI which shows white backgrounds or bad contrast:
Thanks for the report - I'll try and get a fix out later tonight
I've made some changes to the logger if you want to try updating. I don't use it that frequently, so feedback is always welcome
I updated just now and the log became all weird if you use the colorblind settings in ublock origin, it's red and blue or possibly purple now.
Even if you fix the incorrect colors, could you also please make it a bit brighter like it is in the main ublock popup?
Use all these colors please, especially the background. This is perfect in my opinion.
I've made some fixes. Please @overdodactyl review and / or I can make a PR.
- Note the unrelated typo (?) fix in
color_variables.css - What should the url-prefix("about:blank ") part do? Can't find a difference when commenting out. And I'm not sure if nested @-moz-document is a valid thing.
- Brightened general font color
- Fixed dropdowns
- I guess everything containing
#netInspector#domInspectorand#netFilteringDialogcan be moved tourl-prefix("moz-extension://blablabla/logger-ui")section (didn't do that yet)
@Kezxo
Why do you use colorblind mode at all?
ShadowFox is made to replace the given colorscheme completely. Of course it is possible to also include rules for colorblind mode but I don't want to invest the time for no good reason and only one person.
Thanks @stonecrusher!
I opened up PR #245 with your commits.
What should the url-prefix("about:blank ") part do?
It's supposed to style the cosmetic filter popup
Can't find a difference when commenting out. And I'm not sure if nested @-moz-document is a valid thing.
You are correct, it appears it got nested somehow and it doesn't work, it should be it's own rule outside the brackets of the previous.
Brightened general font color... Fixed dropdowns
Looks good!
I guess everything containing
#netInspector#domInspectorand#netFilteringDialogcan be moved tourl-prefix("moz-extension://blablabla/logger-ui")section (didn't do that yet)
Agreed.
Looks like the way I made the PR doesn't give me any write access...can you either move the about:blank into it's own rule or submit a new PR with the changes that I can then edit?
Added about:blank section again
Reordered by element
Added you as collaborator in my fork (check you're on branch patch-1)
Thanks!
Why do you use colorblind mode at all?
Well, I'm colorblind.
ShadowFox is made to replace the given colorscheme completely. Of course it is possible to also include rules for colorblind mode but I don't want to invest the time for no good reason and only one person.
That should not be necessary since it worked great before? Shadowfox worked great with the old logger, it just used the colors that the extension used (besides the bright ones). Just look at the screenshot I posted, that part of ublock works great with shadowfox.
What benefits do you have by turning colorblind mode on if ShadowFox replaces everything anyway?
However, at the moment SF does not support colorblind mode and it would be better to turn it off and then tell what's wrong.
By the way maybe I'll make a rewrite of the whole uBO dark theme based on the original rules - colorblind mode not included, shouldn't be necessary. uBO itself relies quite a lot on colors so depending on the type of colorblindness it cannot be fixed. Should take into account the most common red-green-blindness though.
Shadowfox doesn't replace everything, just look at the screenshot. Even though colorblind mode isn't supported that popup menu is still way more usable to me in colorblind mode.
The main problem I have right now is that it seems that the colorblind settings are not getting applied when using the logger with shadowfox, this was not a problem before ublock updated it's logger. Blocked objects in the log should be blue with colorblind mode on, with shadowfox they are red. This should be easy to reproduce.
Forget what I said about the brighter thing, that's barely an issue. I just want the original block and allow colors
Examples of inconsistent colors in the logger with shadowfox:
This is wrong, should be blue:
This should also be blue:
This is correct, how it should look.
I'm not asking you to fix or support anything you don't feel like, I just want to make my issue clear and then you can make a call how much work this is or not.
I've made a PR which should fix it back to the original uBO colorblind colors.
Looks like the element picker went back to being white.
@SheepKid12 Can't reproduce. You probably didn't use the new version of ublock_origin.css?