Tabs Bar Color
GTK66 opened this issue · comments
In Firefox 65 The Tabs Bar takes on the color that is set in windows 10.. In order to make it dark you either have to change the color settings in Windows 10 or leave out the check mark in Windows 10 Colors in Title Bars and Windows borders as shown in the image below. This will make the Tabs bar dark again, but it messes up Windows 10's Programs. If I leave the the check mark out, all programs in Windows 10 will have a bright tool bar. I use ShadowFox to get away from bright colors.
This issue became a problem with Firefox 65 as Mozilla changed something with the bars. This did not happen in Firefox 64. See the attached image link. This is not an issue with the default dark theme it is in ShadowFox. A Simple CSS script may fix this.
This is not an issue with the default dark theme it is in ShadowFox
Are you sure of this? ShadowFox doesn't have any styling for the tabs bar, so its color should be entirely dependent on Firefox/your Windows setup
I'm not entirely sure how that could be - as mentioned above, ShadowFox doesn't touch the tab bar, nor take into account any Windows based colors/themes. The styling for that is entirely based on Firefox (how they utilize your Windows theme, I am unsure).
Based on your screen shots in arguablykomodo/shadowfox-updater#31, however, it doesn't look like you have the FF dark theme in use (the address bar, for example, is white).
Whether Firefox changed something to no longer allow you to use the default theme without a certain Windows config, I am not sure.
If that's the case I may need to look into overriding the tab color, but as it stands it is not ShadowFox causing bright colors in your tab region.
@loopy750, any insights here by chance?
Gotcha, thanks
So generally speaking, in the past I've opted to stay as consistant with Firefox's look as possible, and make ShadowFox simply a complementary feature to the available dark theme rather than res-style/change things that are designed with intention for the dark theme.
I would tend to agree though that having a colored tab area doesn't fit great with ShadowFox, so maybe this is a case worth making an exception for.
I don't use Windows though, so I'm not sure how this theming fits in with their ecosystem/how users would feel about me overriding it.
I guess another possibility would be to add an option in the updater that could append something to the effect of
#TabsToolbar {
background: var(--tone-9) !important;
}to userChrome.css (pinging @SrKomodo in case you have any thoughts/opinions on this).
Feedback from other Windows users would be greatly appreciated as well.
Relevant reddit thread with a screenshot of how Firefox is effected:
https://old.reddit.com/r/firefox/comments/9ukhed/nightly_dark_theme_menu_bar_no_longer_dark/
It doesn't look too bad with the light theme, but does look horrible with the dark theme.
/* Dark theme */
.tab-background:not([selected]):-moz-lwtheme-brighttext,
.browser-toolbar.titlebar-color:-moz-lwtheme-brighttext {
background-color: #0C0C0D !important;
color: #F9F9FA !important;
}
/* Light theme */
.tab-background:not([selected]):-moz-lwtheme-darktext,
.browser-toolbar.titlebar-color:-moz-lwtheme-darktext {
background-color: #E3E4E6 !important;
color: #18191A !important;
}No this did not work unless I placed in the wrong place. I placed it at user name\AppData\Roaming\Mozilla\Firefox\Profiles\bjaip11i.default\chrome
It's impossible for me to know if that is the correct location for you, but it should be in your userChrome.css file.
It was added to ShadowFox in 9d59a01 though, so if you use the updater/update your ShadowFox code, you will have it.
The code works on macOS to change the tab bar area... @loopy750 is the current version of SF working for you to adjust the tab area in Windows?
This is what I was trying to tell you. So in order for SgadowFox to work properly from Fx 65 on out the code needs changed. See Below:
That change is not relevant to ShadowFox; the significant change was that Firefox now styles the tab area based on your Windows theme. It didn't do this before, and as such I did not include any code to style that area (because the default dark theme handled it).
Then why did this work fine with Firefox 64, It does NOT work with 65
Because, as said before, Mozilla just started styling Firefox with Windows' colors. It has nothing to do with the other reasons you mentioned and ShadowFox has never styled the tab area.
users will have to stay on Firefox 64 or change their Color settings in Windows 10
No, I made changes (as stated above) to address it.
If this is what ShadowFox calls customer service then I do not need your program.
I directed you to the right location to submit an issue when you opened one that didn't even make sense in the wrong repository, and I subsequently made changes to the project to address the problem; I'm not sure what else you want.
I am maintaining this project in my free time along with the help of some others. I am not "customer service," and you should never expect that from any open-source project that does not seek or accept any form of payment.
I am done with your POS product
¯\(ツ)/¯
Again, I believe the issue addressed here has been fixed. If anyone else finds that this is not the case, please open up a new issue and we will get it resolved there as I am locking this conversation.
The code works on macOS to change the tab bar area... @loopy750 is the current version of SF working for you to adjust the tab area in Windows?
Hi, works fine for me...
With Shadowfox: https://i.imgur.com/RPbhxxm.png
Without shadowfox: https://i.imgur.com/4VWpugR.png
Perfect, thanks for the help and the update!