osmandapp / OsmAnd-iOS

OsmAnd for iOS

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Exit number and circle from roundabout turn arrow isn't visible in Dark mode

dmpr0 opened this issue · comments

Description

Circle part of roundabout asset isn't visible in Dark mode.

How to reproduce

  • Calculate route from 52.23996 4.50341 to 52.23599 4.50283
  • Turn on Simulation

Actual result

Light Dark

Expected result

  • Whole icon is fully visible

ToDo

We need to start using colors from assets for navigation arrows, currently the defined in OAColors.h

  • Use navArrowColor from assets, instead of color_nav_arrow
  • Use navArrowDistantColor from assets, instead of color_nav_arrow_distant
  • Use navArrowImminentColor from assets, instead of color_nav_arrow_imminent
  • Stroke, use navArrowStrokeColor for stroke outisde arrow and circle
  • Exit number, use widgetValueColor

Circle

Screenshot
Current Proposed
  • Fill circle shape, use color navArrowCircleColor

Environment
OsmAnd Version: 4.7.2.6
iOS version: 17.3
Device model: XS Max

Review

Tested on TestFlight 4.7.3.1

  • Crashed first time

Screenshot
iOS Android
Video
iOS Android
iOSRound.mov
AndRound.mov
  • Roundabout turn arrows is missed with Next turn widget

Looks like already fixed.

Screenshot 2024-04-08 at 14 07 35