suggestion: testing instructions

Question

suggestion: testing instructions

iuioiua opened this issue 2 years ago · comments

Hi team, I'd like to contribute to this great module. However, there aren't any testing instructions. Is it possible to have this added so contributors can do so?

Asher Gomez · Answer 1 · Mon Dec 05 2022 05:37:30 GMT+0800 (China Standard Time)

Gently pinging

Asher Gomez · Answer 2 · Sat Jan 14 2023 13:22:13 GMT+0800 (China Standard Time)

I am gently pinging once more. I'd love to help make this repo better! 🙂

CC @cdschexnide and @mdwatson988

cdschexnide · Answer 3 · Fri Jan 20 2023 23:45:56 GMT+0800 (China Standard Time)

Hi @iuioiua. Sorry for the delayed response. I started a new job in October last year and we use GitLab so I'm rarely on GitHub anymore. I believe if you fork and clone the repo, you can locally make whatever changes you'd like to add. Then once you submit the pull request and one of us approves it, you'd be added as a contributor.

Asher Gomez · Answer 4 · Sat Jan 21 2023 05:06:58 GMT+0800 (China Standard Time)

Great! Thank you 🙏🏾

However, I was more referring to testing. If I make a change what test can I run to ensure I haven't broken anything?

cdschexnide · Answer 5 · Sat Jan 21 2023 05:25:36 GMT+0800 (China Standard Time)

This is the test file: https://github.com/oslabs-beta/Deno-Redlock/blob/main/src/single.test.ts

Running this test file in the terminal will verify that your additions do not interfere with proper lock functionality.

Asher Gomez · Answer 6 · Wed Feb 01 2023 11:33:09 GMT+0800 (China Standard Time)

Ah, I didn't realise there was a src/single.test.ts. I was using src/testing/single.test.ts. Thanks!