resize POST call?

Question

resize POST call?

elixx opened this issue 4 years ago · comments

I'm running down an issue that I thought was originally due to CloudFlare (524 request time limit exceeded) but now I am seeing the same thing direct to nginx (502 error from nginx) or direct to the npm serve process on :8000. There is a POST to .../resize that never seems to complete:

Any guidance would be appreciated

elixx · Answer 1 · Thu May 28 2020 22:56:45 GMT+0800 (China Standard Time)

To reproduce would be to spawn an Xterm and resize the window.

Anders Evenrud · Answer 2 · Thu May 28 2020 23:14:02 GMT+0800 (China Standard Time)

Hi, and thanks!

Seems like the endpoint works, but it does not respond with anything 🤦

https://github.com/os-js/osjs-xterm-application/blob/master/server.js#L149

Ideally it should just send OK with a 200 or something.

Anders Evenrud · Answer 3 · Fri May 29 2020 01:04:53 GMT+0800 (China Standard Time)

I published an update to npm that should fix this issue. Run npm update @osjs/xterm-application and restart the server :)

Thanks for reporting!

elixx · Answer 4 · Fri May 29 2020 01:56:21 GMT+0800 (China Standard Time)

Awesome, that works great, and fixes that bug although didn't resolve the problem I was originally running down.
Could we have ping / keepalive on the Xterm websocket, as well?

Anders Evenrud · Answer 5 · Fri May 29 2020 02:02:19 GMT+0800 (China Standard Time)

Could we have ping / keepalive on the Xterm websocket, as well?

Feel free to open up an issue about this. Should be fairly simple to implement :)