It would be great to be able to copy/move files between folders
valp124 opened this issue · comments
Seems to be unavailable currently (no copy/paste buttons in the context menu). Drag and drop is possible but results in no action.
I have a somewhat working clipboard solution ready, so I guess this would be a good place to test it out
I've started work on this and opened the following pull requests:
FYI I actually found a bug in the copy/move functionality in the server. So I'd advice upgrading @osjs/server :)
Thanks for the heads up!!
If you update @osjs/client and @osjs/filemanager-application you should now be able to copy/cut and paste files via the context menu as well as a new Edit menubar item :)
I also just pushed another update of @osjs/filemanager-application that adds in proper drop support.
What an awesome dude you are!!
@andersevenrud ah this is awesome!
I've noticed when slightly moving a file and releasing, I receive an alert about source and destination being the same. It's just a minor annoyance, but can this alert be squashed? I am triggering it a lot just from touching files a bit, also maybe I'm too click-happy.
@josephjeno Aha. I'll add a check to prevent this :)
@josephjeno Just published an update that takes care of this. Thanks!
Thank you so much, Anders, from both @josephjeno and me!!
And since we're on the subject ... :) No urgency at all, these would be bells and whistles, but it'd be super convenient to be able to do two more things:
- Drag and drop files into a folder within the same window, as such
- Drag and drop folders (in addition to files), either to other folders or to the desktop, as such
(I suppose, dragging to the desktop would then create a shortcut rather than a copy.)
Again, these are more ideas than requests, not critical at all!
Drag and drop files into a folder within the same window, as such
I'll look into it. The UI component should support this
Drag and drop folders (in addition to files), either to other folders or to the desktop, as such
I'm not sure why I disabled dragging of folders.... but I've got a hunch that folder copy was not supported when I first added DnD. So I'll look into this again now that it most likely works just fine.
The desktop icons should support folders just fine as well since this is using the underlying VFS. I even see in the code that there's a conditional to open folders using File Manager :)
(I suppose, dragging to the desktop would then create a shortcut rather than a copy.)
It's possible to hold shift when dropping to get a contextmenu for creating shortcuts instead of copy on the desktop. However I've seen some issues relating to this that I'll look into.
(I suppose, dragging to the desktop would then create a shortcut rather than a copy.)
But having folders as shortcuts by default is probably a good idea
Right, exactly, open File Manager when double-clicking on a folder!