Multi Select rows for doing bulk operation like delete,copy and rename

Question

Multi Select rows for doing bulk operation like delete,copy and rename

miladhashemi opened this issue 4 years ago · comments

SeyedMilad Hashemi commented 4 years ago

Is it possible to add multi select rows capability in file manager and do bulk operation for delete,copy,move?

Scenario

I select two rows(ctrl+leftClick) and click on delete button.

Expected Result

System returns an array of two pathes. finally delete them in an iterate manner.

Anders Evenrud · Answer 1 · Sun Jun 28 2020 03:22:38 GMT+0800 (China Standard Time)

This will require updates in two areas:

https://github.com/os-js/osjs-gui/blob/master/src/components/ListView.js - The selectedIndex needs to be changed to an array if a property named multiselect is set to true. As well as update the selection events to reflect this.
FileManager UI needs to use mutliselect, and all event emitters needs to use arrays of refs, and not direct file refs.

So it should be fairly simple to implement this

Anders Evenrud · Answer 2 · Sun Jun 28 2020 06:00:56 GMT+0800 (China Standard Time)

I've started on implementing this. Here's a sneak preview:

Ref:

SeyedMilad Hashemi · Answer 3 · Sun Jun 28 2020 12:48:02 GMT+0800 (China Standard Time)

Actually I think beside gui, the VFS and Adapter needs to be changed too.
One part of problem is in osjs/gui that must select multiple rows, it seem you handled it.
Next step we need Adapter supports operations like delete on it.
Adapter operates on array of vfs.oject instead of single vfs.object.

Anders Evenrud · Answer 4 · Sun Jun 28 2020 22:16:09 GMT+0800 (China Standard Time)

The VFS does not need any changes The file manager can just use Promise.all to handle bulk operations.

Anders Evenrud · Answer 5 · Fri Jul 03 2020 06:33:03 GMT+0800 (China Standard Time)

I believe I've made all of the appropriate changes to the filemanager application, and now need to finish up the ListView component changes and I can put out a beta on npm for testing :)

SeyedMilad Hashemi · Answer 6 · Sun Jul 05 2020 03:29:11 GMT+0800 (China Standard Time)

Oh, Thank U Andres. How can I test beta version? Is it on npm rep at moment?

Anders Evenrud · Answer 7 · Mon Jul 06 2020 22:45:53 GMT+0800 (China Standard Time)

I haven't published it onto npm yet as I'm not 100% done.

You can try this out by checking out the code locally.

SeyedMilad Hashemi · Answer 8 · Sun Oct 04 2020 15:15:38 GMT+0800 (China Standard Time)

I tested multiselect option,but didnt works.
Even readdir throws bellow warning message:

TypeError: files.map is not a function

Also throws bellow warning as i click on edit menu:

TypeError: items.some is not a function

for readfile throws bellow error:

Uncaught TypeError: data.forEach is not a function

Anders Evenrud · Answer 9 · Mon Oct 05 2020 04:06:35 GMT+0800 (China Standard Time)

I haven't looked at it myself, but I'm pretty sure this is because I made some changes in the master codebase, then remastered this branch which made some calls invalid.

I'll update this ASAP.

hello-smile6 · Answer 10 · Mon Feb 14 2022 07:22:56 GMT+0800 (China Standard Time)

I haven't looked at it myself, but I'm pretty sure this is because I made some changes in the master codebase, then remastered this branch which made some calls invalid.

I'll update this ASAP.

Status?

Anders Evenrud · Answer 11 · Tue Feb 15 2022 01:30:48 GMT+0800 (China Standard Time)

Status?

I always follow up in issues with updates. As you can see, I haven't really found any time for this.

Aaron Meese · Answer 12 · Sun Jul 24 2022 04:22:03 GMT+0800 (China Standard Time)

I tested multiselect option,but didnt works. Even readdir throws bellow warning message:

TypeError: files.map is not a function

Also throws bellow warning as i click on edit menu:

TypeError: items.some is not a function

for readfile throws bellow error:

Uncaught TypeError: data.forEach is not a function

@miladhashemi I had that same problem a little bit ago, before realizing that you also need to update your local code with the linked unmerged LiveView PR on the GUI repository. Once you have those changes synced you will no longer experience those error messages. The PR still isn't perfect, the functionality isn't entirely up to what was initially requested quite yet, but I am going to try to get this working on my implementation then add to the PR and get this feature fully supported.