Deprecate static default window option configuration
andersevenrud opened this issue · comments
@josephjeno Just a small heads-up on this as I thought you might find it useful.
TL;DR: I'm adding configuration options to override arbitrary windows default options. This will make the default File Manager window size override via client configuration that I made for you obsolete.
I'll keep the customization for a while so you'll have good time to migrate the changes :). The updates in @osjs/client won't break anything for you anyways, so it's totally safe and just requires a minor change to your src/client/config.js file.
Ah thanks man for the heads up! Hope all is well with you.
@josephjeno I just updated the linked PR with a bit more detained information about the workings of this.
I'm doing very well, thank you. I hope you're doing well too 😄
@andersevenrud since the linked PR has been merged, is this issue good to be closed out?
Yup @ajmeese7 . The PR didn't contain a fixes reference so this was not auto-closed.