os-js / osjs-filemanager-application

OS.js File Manager Application

Home Page:https://manual.os-js.org/v3/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

unnecessary invoking function

msjavan opened this issue · comments

Every time I opened any menu in filemanager, getMenuMountpoints function invoked. This is not an optimal job. I think It should be invoked just if "Go" menu selected.

This is because the mountpoints is not [currently] stored in the application state.
And seeing how getMenuMountpoints only maps an array, it doesn't really cost anything.

However, feel free to submit a patch for this is you want.

I've started a refactor of this application here: #14

So this won't be an issue anymore (soon) :)

This change is now out :)