Add "Date modified" column to File Manager and FileDialog
josephjeno opened this issue · comments
It would be very helpful if OS.js included a Date modified column. We use a few apps in OS.js that generate long, very similarly named MATLAB files. Before long it becomes difficult to navigate.
The VFS file objects have timestamps, so it could be added as a column:
- https://github.com/os-js/osjs-filemanager-application/blob/master/index.js#L162
- https://github.com/os-js/osjs-filemanager-application/blob/master/index.js#L467
The stat property of a VFS file contains the following: https://nodejs.org/api/fs.html#fs_class_fs_stats
It would probably be best to make this column trigger via an application setting that is selectable from a menu or something.
It would probably be best to make this column trigger via an application setting that is selectable from a menu or something.
Just because the columns cannot currently be resized, and the date string might be pretty long.
Maybe some sort of right click context menu on the column headers?
Or maybe just the "View" menu 🤔
I've started on this here: #12
However, this application needs a bit of a cleanup as well as persistent settings 🤔
@josephjeno I've started a refactor of this application here: #14
This will be included in that update :)
@josephjeno Feel free to test out that branch for yourself. I think I got everything working as it was, but needs testing 🙂
Ran it through the paces this morning and everything works great after the cleanup. Persistent settings would be awesome. Currently it forgets my view settings (show hidden files, show date column) after closing and reopening the app.
Cool! Persistent settings is supported in apps, so technically I just have to wire it up and run a save method. I'll fix that asap :)
@josephjeno I just pushed another commit that makes settings persistent. So if you wanna give that a go, it's there waiting for you ;)
Should I make it so that all open FileManager instances gets updated whenever you change a setting ? 🤔
Edit Added just in case (but disabled) in a6c6e83 😊
Good question! I messed around with Windows File Explorer settings and changes to Display Hidden Items and Display File Name Extensions is reflected immediately across all instances. That... makes sense to me I think. For the most part I think our users will just set the settings once and leave it.
I uncommented the line required for that to work. So if you try again it should be reflected across all open instances :)
It's working perfect man!
Nice :) I'll do another run through of all the features after the refactor, then release it (tomorrow probably).
Thanks so much Anders, have a great weekend!
1.4.0 is now out :)