Inconsistent use of init & extra containers on jobs
adamstrawson opened this issue · comments
Preflight checklist
- I could not find a solution in the existing issues, docs, nor discussions.
- I agree to follow this project's Code of Conduct.
- I have read and am following this repository's Contribution Guidelines.
- This issue affects my Ory Cloud project.
- I have joined the Ory Community Slack.
- I am signed up to the Ory Security Patch Newsletter.
Describe the bug
The Hydra helm-chart job
resource has an incorrectly wrapped conditional, extraContainers
is wrapped within extraInitContainers
conditional, meaning you cant define an extra container without also setting extraInitContainers
.
Keto & Kratos was also missing extraInitContainers
entirely too.
Reproducing the bug
helm install -f values.yaml ory/hydra
# values.yaml
job:
extraContainers: |
- name: helloworld
image: helloword:latest
The hellowold
sidecar container will not be included.
Relevant log output
No response
Relevant configuration
No response
Version
0.25.3
On which operating system are you observing this issue?
No response
In which environment are you deploying?
No response
Additional Context
No response
Closed by #508