ory / fosite

Extensible security first OAuth 2.0 and OpenID Connect SDK for Go.

Home Page:https://www.ory.sh/?utm_source=github&utm_medium=banner&utm_campaign=fosite

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

NewDefaultSession's SetSubject should set IDTokenClaims as well

mitar opened this issue · comments

Preflight checklist

Ory Network Project

No response

Describe your problem

openid.Session requires subject to be set. openid.NewDefaultSession() returns an openid.DefaultSession without subject set. It provides SetSubject to set the subject, but calling it still does not make the session have subject. It has to be set in IDTokenClaims as well.

Describe your ideal solution

		session := openid.NewDefaultSession()
		session.SetSubject(subject)

Should be enough.

Workarounds or alternatives

One currently has to set it manually:


		session := openid.NewDefaultSession()
		session.SetSubject(subject)
		session.IDTokenClaims().Subject = subject

Version

v0.46.1-0.20240213123944-f38352921f22

Additional Context

No response