Git credentials are not propagated to new kernel terminals
astrojuanlu opened this issue · comments
Describe the bug
The new "kernel terminals" as opposed to the regular/classic/native terminals (we should come up with some unified terminology here) does not inherit the git credentials configured in the Configure JupyterLab page. As such, the current options are
- Setting them in every project, or
- Quitting the kernel terminal and using git from the regular terminal.
I consider this a bug because it's a breaking change with respect to the old default behavior.
Expected behavior
As a user, I want to transparently use git with the default terminals so that I don't have to figure out credentials twice or use a distinct terminal for git.
To Reproduce
Steps to reproduce the behavior:
- Configure git credentials as suggested in https://docs.orchest.io/en/stable/fundamentals/projects.html#using-git-inside-orchest-projects
- Create a project
- Go to JupyterLab
- Open a new Terminal
- Run
git config --get user.email
and see that nothing comes up ❌ - Exit the terminal to a regular, non-SSH terminal, rerun
git config --get user.email
, and see the proper value ✔️
Environment
- Orchest's version (in the settings page): 2022.10.5
(We are planning to properly tackle this in #483.)
For now, if you want to use git inside Environment shells then, as the name suggests, you need to configure it in the respective Environment (the shell is executes within that Environment).
Does that make sense? 😇
Good to know this is in scope for gh-483 😁 Yes, the workaround is lightweight enough.