orbitz / opass

Simple password db

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

opam packaging

dlobraico opened this issue · comments

I made a go at packaging opass for opam. It seems like the OCAMLPATH issue which you attempted to fix with commit 6694406 is cropping up again ("ocamlfind: Package 'db' not found"). Manually setting the OCAMLPATH before running opam install opass seems to resolve the issue so I would guess that the way that opam is running make is somehow preventing the OCAMLPATH from being set as you expect.

I'm also surprised that setting the environment variable in the Makefile worked at all because I was under the impression that make runs each rule in its own independent shell. In any case, perhaps it would be good to make the Makefiles not depend on this if possible? I'm taking a look now and will make a pull request if I come up with anything good.

Here is my attempt at packaging opass for opam: https://gist.github.com/4414043

Perhaps the solution is to ocamlfind install these libraries (db, password, editable) before continuing on to compile the contents of main.

Okay, I did some slight reorganization and converted opass to use ocamlbuild. I'm going to make a pull request here with my branch and also a request with the opam-repository folks.

After merging this I realized it moves all source files into a common location and then builds out to subdirs. This is not what I want, the lib dir should be orthogonal sub projects that can be pulled out into their own repos if I want. I'm going to revert the merge for the time being.

What OS are you compiling on btw?

Mac OS 10.8.2.

What directory structure do you prefer?

I'd like all of the code to be split up in it appropriate subdirectories under lib/, basically as subprojects. How the code is split up now.

Alright, I think ocamlbuild should handle that fine. Can the main
subdirectory still be in bin and then the rest of the subdirectories
be within lib?

On 02/21, orbitz wrote:

I'd like all of the code to be split up in it appropriate subdirectories under lib/, basically as subprojects. How the code is split up now.


Reply to this email directly or view it on GitHub:
#4 (comment)

This should be fixed in version 1.0.0.