orbitersim / orbiter

Open-source repository of Orbiter Space Flight Simulator

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Feature request : include release builds in artifacts

supersonic71 opened this issue · comments

This is to let more people who want to help with testing.
Correct me if I'm wrong, but currently Github actions produce an Orbiter build which is "Debug" Version.
So people who don't have Visual Studio installed can't run these artifacts as it requires some debug dlls (https://www.orbiter-forum.com/threads/skybolt-client-development.40057/page-5#post-599087).
Would it be possible to also include a "Release" version in the artifacts? Should be faster to run too.

I wasn't even aware that the artifacts were packing debug builds. The build script specifies configuration "RelWithDebInfo", but this is done on the build rather than the config step, which may be ignored by the Ninja generator.

For Ninja, the solution may be to add the flag
-DCMAKE_BUILD_TYPE=Release
on the config step.

Testing this will have to wait because I will be out of the loop for a few weeks. I'm just putting this comment here to remind myself.