Subfolders in Windows

Question

Subfolders in Windows

abalsekar opened this issue 5 years ago · comments

Great module, but wasn't working for me for any content in subfolders under the root bucket. I'm developing on Windows, deploying on Linux.

Seems that the full paths returned by the s3Files.createKeyStream method in s3-files.js are platform dependent. I'm sure they should always be forward slashes (as used by S3).

I added a line to correct the slashes
paths = paths.map(path => path.replace(/\/g,"/"));
just before the return streamify(paths) around line 36.

Not your bug - but hope this helps someone. Perhaps mention in the README??

Ronald Luitwieler · Answer 1 · Sun Sep 01 2019 20:09:23 GMT+0800 (China Standard Time)

Hi @abalsekar, thanks for reporting. I've patched s3-files (2.0.1). Can you try if this solves the issue?

Appreciate your help.

abalsekar · Answer 2 · Tue Sep 03 2019 04:42:48 GMT+0800 (China Standard Time)

Yes - fixed. Thanks. Best, AB.

…

On Sun, 1 Sep 2019 at 13:09, Ronald Luitwieler ***@***.***> wrote: Hi @abalsekar <https://github.com/abalsekar>, thanks for reporting. I've patched s3-files (2.0.1). Can you try if this solves the issue? Appreciate your help. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#62?email_source=notifications&email_token=AA3AVNQICQ7OEBQIKRQ3ANLQHOWHHA5CNFSM4ISU3BLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5UBAIA#issuecomment-526913568>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA3AVNSQMR5FHR2WZQOIOCLQHOWHHANCNFSM4ISU3BLA> .