oraclesorg / treasury

Treasury is a solidity contract for Cross Chain Crowdsale where buyers can exchange tokens for coins

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

calling tokenDepositEvent from transferFrom

lorien opened this issue · comments

Now if tokens are sent to treasury (with transfer method) token calls tokenDepositEvent from treasury contract.
I think tokenDepositEvent should be called also if tokens are sent with transferFrom method. What do you think?

For me too. I think, this event should be spread to both transfer methods.

function transferFrom(address _from, address _to, uint256 _value) public returns (bool) {

I am not sure who should receive tokens if transferFrom transfers tokens to treasury.:

  • msg.sender?
  • _from?

Another possible solution of transferFrom issue: just restrict transferFrom to send tokens to treasury address.

Good idea with restriction

Done in 5a0546b