Expose commands' status for commands

[rajatWipfli]

Select the SuiteCloud tool where you encountered the issue

SuiteCloud Extension for VSCode

Version of the SuiteCloud Tool

v1.4.3

Operating system

Windows 10

Node Version / VSCode Version

v.18.15.0, V1.80

JAVA Version

17.x

Bug description

Is it possible to get the command's result?

I think if we return a value e.g. return action.run from

netsuite-suitecloud-sdk/packages/vscode-extension/src/suitecloud.ts

Lines 38 to 45 in fc85dfc

 return vscode.commands.registerCommand(command, (uri?: vscode.Uri) => { 
 	if (!sdkDependenciesDownloadedAndValidated) { 
 		vscode.window.showWarningMessage(translationService.getMessage(EXTENSION_INSTALLATION.WARNING.VALIDATING_SDK_DEPENDENCIES)); 
 		return; 
 	} 
 	// Called from a context menu, we receive uri info related to the selected file. 
 	action.run(uri); 
 }); 

. It will expose that status.

I am building an internal extension for our project workflows which triggers SuiteClound extension commands. These commands are async but the resulting promise is completed immediately because we don't wait on the action to run.

I am calling executeCommand where docs say that it will return the value of the handler function.

Steps To Reproduce

NA

Actual Output

No response

Expected Output

No response

Anything else?

No response

[David Rebolleda Mir]

As this is not causing any problem to the extension itself, I'll mark the issue as enhancement.
Maybe we could be: return action.run(uri); on line 44 so your code could be awaiting for the resulting promise.

We'll take a look and evaluate.

[rajatWipfli]

Yeah, thanks.

[rajatWipfli]

@davidecorreu No rush but did you get the chance to review this? I am trying to understand the next steps. Do you have any estimates on when action would be taken on this?

[rajatWipfli]

Any plan for this?

[touraj vaziri]

Hi @rajatWipfli we will go over it and evaluate the fix.