opsdroid / opsdroid.github.io

🌐 The website for opsdroid

Home Page:https://opsdroid.github.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Cache opsdroid icon for chat demo

pjbollinger opened this issue · comments

While working on adding blog posts to the site, I noticed a network request every time the opsdroid icon appeared in the chat demo. Ideally, this should be stored on the local machine at first load so the request never has to be completed again, until the page reloads.

screen shot 2017-10-08 at 10 00 28 am

This is definitely something that should be fixed. Thanks!

I should add that I experience this lack of cache in Safari on High Sierra (will get specific numbers later) but not on Google Chrome Canary 57.0.2985.0 on Windows 7. Not sure, but I feel it’s related to how Safari determines cache and how Jekyll server reports what can be cached.

I want to do my 1st contribution. Can I work on this issue?
Can you please help me with that?

hey @jacobtomlinson I would like to work on this issue, is it still open @pjbollinger ?

@himansh-gjr Feel free to open a PR with this changes as this is still open, thank you

Sure, Thanks !