opsdisk / yagooglesearch

Yet another googlesearch - A Python library for executing intelligent, realistic-looking, and tunable Google searches.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Some valid `lang_result` with capitalized parts will be incorrectly fallback to the `lang_en`

libenc opened this issue · comments

Some valid lang_results that have capitalized parts present:

lang_zh-CN=Chinese (Simplified)
lang_zh-TW=Chinese (Traditional)

Codes in __init__.py L147 and L169-L175 will cause these lang_result to be incorrectly fallback to the lang_en:

...
self.lang_result = lang_result.lower()
...
# Argument checks.
if self.lang_result not in result_languages_list:
    ROOT_LOGGER.error(
        f"{self.lang_result} is not a valid language result.  See {result_languages_file} for the list of valid "
        'languages.  Setting lang_result to "lang_en".'
    )
    self.lang_result = "lang_en"
...

Hi @libenc - good catch! I'll take a look at the PR.


Viewing source in view-source:https://www.google.com/advanced_search

<li class="goog-menuitem" value="lang_af">Afrikaans</li>
<li class="goog-menuitem" value="lang_ar">Arabic</li>
<li class="goog-menuitem" value="lang_hy">Armenian</li>
<li class="goog-menuitem" value="lang_be">Belarusian</li>
<li class="goog-menuitem" value="lang_bg">Bulgarian</li>
<li class="goog-menuitem" value="lang_ca">Catalan</li>
<li class="goog-menuitem" value="lang_zh-CN">Chinese (Simplified)</li>
<li class="goog-menuitem" value="lang_zh-TW">Chinese (Traditional)</li>
<li class="goog-menuitem" value="lang_hr">Croatian</li>
<li class="goog-menuitem" value="lang_cs">Czech</li>
<li class="goog-menuitem" value="lang_da">Danish</li>
<li class="goog-menuitem" value="lang_nl">Dutch</li>
<li class="goog-menuitem" value="lang_en">English</li>
<li class="goog-menuitem" value="lang_eo">Esperanto</li>
<li class="goog-menuitem" value="lang_et">Estonian</li>
<li class="goog-menuitem" value="lang_tl">Filipino</li>
<li class="goog-menuitem" value="lang_fi">Finnish</li>
<li class="goog-menuitem" value="lang_fr">French</li>
<li class="goog-menuitem" value="lang_de">German</li>
<li class="goog-menuitem" value="lang_el">Greek</li>
<li class="goog-menuitem" value="lang_iw">Hebrew</li>
<li class="goog-menuitem" value="lang_hi">Hindi</li>
<li class="goog-menuitem" value="lang_hu">Hungarian</li>
<li class="goog-menuitem" value="lang_is">Icelandic</li>
<li class="goog-menuitem" value="lang_id">Indonesian</li>
<li class="goog-menuitem" value="lang_it">Italian</li>
<li class="goog-menuitem" value="lang_ja">Japanese</li>
<li class="goog-menuitem" value="lang_ko">Korean</li>
<li class="goog-menuitem" value="lang_lv">Latvian</li>
<li class="goog-menuitem" value="lang_lt">Lithuanian</li>
<li class="goog-menuitem" value="lang_no">Norwegian</li>
<li class="goog-menuitem" value="lang_fa">Persian</li>
<li class="goog-menuitem" value="lang_pl">Polish</li>
<li class="goog-menuitem" value="lang_pt">Portuguese</li>
<li class="goog-menuitem" value="lang_ro">Romanian</li>
<li class="goog-menuitem" value="lang_ru">Russian</li>
<li class="goog-menuitem" value="lang_sr">Serbian</li>
<li class="goog-menuitem" value="lang_sk">Slovak</li>
<li class="goog-menuitem" value="lang_sl">Slovenian</li>
<li class="goog-menuitem" value="lang_es">Spanish</li>
<li class="goog-menuitem" value="lang_sw">Swahili</li>
<li class="goog-menuitem" value="lang_sv">Swedish</li>
<li class="goog-menuitem" value="lang_th">Thai</li>
<li class="goog-menuitem" value="lang_tr">Turkish</li>
<li class="goog-menuitem" value="lang_uk">Ukrainian</li>
<li class="goog-menuitem" value="lang_vi">Vietnamese</li>