Giters

operasoftware / gn-opera

A fork of https://gn.googlesource.com/gn/ initially created to add Jumbo build mechanism with the support for Visual Studio projects.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

gn check doesn't work for jumbo files

bratell-at-opera opened this issue · comments

commented

command_check.cc follows includes but not well enough so it will not find includes done through jumbified files.

commented

I think there are two possible problems that have to be solved.

  1. I think the header checker (header_checker.cc) might only be looking at files ending with a .h.
  2. The checker will only complain about files listed in sources (that is why it's important to also list all headers in sources), and that might prevent it from following dependencies through jumbo files since they are no longer in sources (or are they?).