opeolluwa / filesync

Quickly and securely share files from Windows, Linux, Mac to Android devices using wifi.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Toggle route Icons on hover or fixed

opeolluwa opened this issue · comments

Checkout the module,
https://github.com/opeolluwa/send-file/blob/master/src/components/AppNavigation.tsx
there are two Icons set, the regular for example, Cog8ToothIcon and the solid, SolidCog8ToothIcon
The icon changes from regular to solid when a route path is hovered on or clicked

Okay seen

Done created a PR

I've seen it @Senninseyi, I made some reviews, could you attend to that so I can merge the PR. I appreciate you time and effort 💯 Well done ❤️

@opeolluwa please where are the reviews so i can see em

I've seen it @Senninseyi, I made some reviews, could you attend to that so I can merge the PR. I appreciate you time and effort 💯 Well done ❤️

@opeolluwa please where are the reviews so I can see em

Check the PR thread #123

Hi @Senninseyi!
There is something I'd like you to work on. But first, the routes paths are pretty much tabs, not conventional routes, as seen on web pages

Can we work around setting none of the tabs as the default? The home tab should not have the solid Icon variant by default.

In the same vein, the color and the Icons should only change on the mouseover event.

Finally, can we animate the transition? Let me know if you need more clarification on this

I would check it out @opeolluwa

thank you

resolved