Encryption commands should print error reason

[Joel Höner]

Commands surrounding encryption fail silently when used incorrectly. e.g.

dd if=/dev/zero bs=512m count=1 of=/tmp/throwaway
sudo zpool create throwaway /tmp/throwaway
sudo zfs create -o encryption=on -o keyformat=passphrase throwaway/enc
>> meow

Will fail (due to the password being to short, I guess?) and have the command return an error code, but won't print any reason on why it failed. The same thing applies for change-key.

I think that printing the reason to stderr would increase usability immensely.

[Russell Hind]

Is this with the 1.9.0 release? There's a bug in that where zfs doesn't print out errors. It's fixed in 1.9.1-rc1.

[Joel Höner]

Yes. Sorry, I should have clarified the version I'm using and didn't realize there was an RC. I'll upgrade and see if it resolves this.

Also, I'm glad that the MacPro monitor stand is finally supported. I nearly wet my pants when reading the changelog :D

[Joel Höner]

Thanks, 1.9.1 indeed resolved the issue!