[BUG] yurt-iot-dock v1.4.1 doesn't match the edgex v3.1.0

[Leo Li]

What happened:
When I deploy yurt-iot-dock v1.4.1, I fount it doesn't match the edgex v3.1.0.

And I see the code logic of the release-v1.4 branch and v1.4.1 tag, which all don't contain the "napa".

openyurt/pkg/yurtiotdock/clients/edgex-foundry/edgexobject.go

Lines 44 to 69 in cb2055b

 func (ep *EdgexDock) CreateDeviceClient() (clients.DeviceInterface, error) { 
 	switch ep.Version { 
 	case "minnesota", "levski", "kamakura", "jakarta": 
 		return edgexcliv2.NewEdgexDeviceClient(ep.CoreMetadataAddr, ep.CoreCommandAddr), nil 
 	default: 
 		return nil, fmt.Errorf("unsupported Edgex version: %v", ep.Version) 
 	} 
 } 
  
 func (ep *EdgexDock) CreateDeviceProfileClient() (clients.DeviceProfileInterface, error) { 
 	switch ep.Version { 
 	case "minnesota", "levski", "kamakura", "jakarta": 
 		return edgexcliv2.NewEdgexDeviceProfile(ep.CoreMetadataAddr), nil 
 	default: 
 		return nil, fmt.Errorf("unsupported Edgex version: %v", ep.Version) 
 	} 
 } 
  
 func (ep *EdgexDock) CreateDeviceServiceClient() (clients.DeviceServiceInterface, error) { 
 	switch ep.Version { 
 	case "minnesota", "levski", "kamakura", "jakarta": 
 		return edgexcliv2.NewEdgexDeviceServiceClient(ep.CoreMetadataAddr), nil 
 	default: 
 		return nil, fmt.Errorf("unsupported Edgex version: %v", ep.Version) 
 	} 
 } 

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

• OpenYurt version:
• Kubernetes version (use kubectl version):
• OS (e.g: cat /etc/os-release):
• Kernel (e.g. uname -a):
• Install tools:
• Others:

others

/kind bug

[rambohe]

@zyjhtangtang @LavenderQAQ PTAL

[摸鱼喵]

@24sama Thank you for raising this issue. In fact, this should already be supported. We just need to add the napa case. Could you submit a pr to help fix this?

[Leo Li]

@LavenderQAQ Got it, and I found this PR:
#1850
Maybe we can cherry-pick this PR into release-v1.4

Another question, if I build the yurt-iot-dock from release-v1.4 source code, Is it will miss some feature or bugfix PR which is compared to official v1.4.1 version?

[摸鱼喵]

@24sama When 1.4 was released, there was no napa release yet. This is a more recent version that we support, and we can fix it directly on master.

[Leo Li]

Thanks @LavenderQAQ , so it means there is only a master branch that supports napa release. And how soon is the official plan to release a new version with napa support? Just like this, we can checkout a new release branch that includes all master PR, and can build it from the release branch.

[rambohe]

Thanks @LavenderQAQ , so it means there is only a master branch that supports napa release. And how soon is the official plan to release a new version with napa support? Just like this, we can checkout a new release branch that includes all master PR, and can build it from the release branch.

@24sama we plan to release OpenYurt v1.5 in the middle of April, please stay in tune.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.