opentracing-contrib / java-web-servlet-filter

OpenTracing Java Web Servlet Filter Instrumentation

NPE if no extracted span context

malafeev opened this issue 7 years ago · comments

Sergei Malafeev commented 7 years ago

https://github.com/opentracing-contrib/java-web-servlet-filter/blob/master/opentracing-web-servlet-filter/src/main/java/io/opentracing/contrib/web/servlet/filter/TracingFilter.java#L151

if extractedContext is null then .asChildOf(extractedContext) here can produce NPE and it does for Lightstep tracer

Gary Brown commented 7 years ago

The asChildOf method should be able to accept a null: https://github.com/opentracing/opentracing-java/blob/master/opentracing-api/src/main/java/io/opentracing/Tracer.java#L106

Sergei Malafeev commented 7 years ago

thanks @objectiser
will file issue against Lightstep

lightstep/lightstep-tracer-java#108