Sign up is broken if username without spaces is taken

Question

Sign up is broken if username without spaces is taken

karenc opened this issue 9 years ago · comments

I tried to sign up on stage1 using my google login karen@karen-chan.com, it resulted in a blank page (See #123)

The traceback says it's "IllegalState" app/controllers/sessions_controller.rb:32 :in `block in callback'

It turns out that when I use my google login, it detected that my username should be "Karen Chan". It checks that there's no user with username "Karen Chan", then it tries to create a user with username "Karen Chan" which gets "santized" by the user model to "KarenChan", but there's already a user with username "KarenChan". So it failed and returned without any status.

JP Slavinsky · Answer 1 · Sat Feb 28 2015 00:08:31 GMT+0800 (China Standard Time)

Your google username has a space? Google!

Dante Soares · Answer 2 · Sat Feb 28 2015 00:16:45 GMT+0800 (China Standard Time)

This explains so many things...

So just need to sanitize the username before we check the existence of the user in the CreateUser routine.

Dante Soares · Answer 3 · Sat Feb 28 2015 00:21:14 GMT+0800 (China Standard Time)

Actually this happens because the OmniauthData class picks your full name as the username if it can't get a username from google.

So the best thing to do is probably to sanitize the name right there.