opensourcepos / opensourcepos

Open Source Point of Sale is a web based point of sale application written in PHP using CodeIgniter framework. It uses MySQL as the data back end and has a Bootstrap 3 based user interface.

Home Page:http://www.opensourcepos.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

PHP 8.0 error when loading https://localhost/poss/public/index.php

harshasuraweera opened this issue · comments

  • PHP version is: 8.0.0

Please write your issue here. If a bug, please make sure to provide as much information as possible including configuration settings (e.g. Decimals set, Tax mode), language, and steps to reproduce the bug.
errors

commented

You are using PHP 8 so downgrade to a 7.3 or 7.4 version?

PHP 8.0 is not supported yet. It will requires changes for sure, starting from Code Igniter.

You are using PHP 8 so downgrade to a 7.3 or 7.4 version?

Solved with 7.4 Thank you

Please leave it open because OSPOS and CI3 don't work with PHP8.0 at the moment: bcit-ci/CodeIgniter#6006

I set version 4.0.0 because that means we need to swithc to CI4, Bootstrap 4 and who knows what else (e.g. Angular/React/View Frontend, REST API)...

Wonder if it would make sense to change framework completely to do all those changes because the upgrade to BS3 and CI3 meant a lot of work!

commented

I found this on the CI4 site.
Codeigniter 4.0.4 does not support PHP 8 The community are working on update will should likely be Codeigniter 4.1 and all php8 error is getting fixed. So it looks like we should wait for 4.1 before any major changes are made.

I was still on PHP 7.2 and upgrade to PHP 7.4 and my installation is faster now. I can't imagine how faster it would get once @objecttothis improvements are merged in.

I set version 4.0.0 because that means we need to swithc to CI4, Bootstrap 4 and who knows what else (e.g. Angular/React/View Frontend, REST API)...

Wonder if it would make sense to change framework completely to do all those changes because the upgrade to BS3 and CI3 meant a lot of work!

I looked at CI4 and according to them it will mean a large rewrite of the code base. That would not be a bad time to look at other frameworks.

I set version 4.0.0 because that means we need to swithc to CI4, Bootstrap 4 and who knows what else (e.g. Angular/React/View Frontend, REST API)...
Wonder if it would make sense to change framework completely to do all those changes because the upgrade to BS3 and CI3 meant a lot of work!

I looked at CI4 and according to them it will mean a large rewrite of the code base. That would not be a bad time to look at other frameworks.

Indeed, I wouldn't consider migrating to CI4 without having reconsidered the whole story here.
Maybe we should start writing down a vision about an OSPOS 4, what would be an ideal target here for a newer and better version?

I think that it would be a complete rewrite indeed, probably we could keep the database model to make it backwards compatible (or just evolve that further).

From this conversation I thought that upgrading to CI4 would be impossible. There is however an upgrade guide and it seems to be a bit of work, but still doable

https://codeigniter4.github.io/userguide/installation/upgrade_4xx.html

From this conversation I thought that upgrading to CI4 would be impossible. There is however an upgrade guide and it seems to be a bit of work, but still doable

https://codeigniter4.github.io/userguide/installation/upgrade_4xx.html

I had also thought that CI4 would involve quite the rewrite since he changed the way many of the functions were called. I'd say that if it's doable we should consider it, but it sounds to me like it would be quite the task.

From this conversation I thought that upgrading to CI4 would be impossible. There is however an upgrade guide and it seems to be a bit of work, but still doable

https://codeigniter4.github.io/userguide/installation/upgrade_4xx.html

@jekkos I just commented on #842 regarding this but after reading the documentation on this, I don't think it would need a complete rewrite, but it does appear that there are syntax changes to the ways that different MVC elements are referenced that will touch almost every Controller, Model and View. Like I said in my comment there, I would be willing to tackle the upgrade.

I'm assigning this to myself because I think it will be resolved by #842.

Can we make it to support at least 8.0? It it good to have support on 8.1 too.
Thanks.

This is resolved in the switch of the codebase to Code igniter 4.x. I am returning from travel in the next few weeks and will resume working on this changeover but without help it's going to be fairly slow.

I wanted to take some time to look why the build on the branch is not working, so we can deploy it and give it a spin..

This is resolved in the switch of the codebase to Code igniter 4.x. I am returning from travel in the next few weeks and will resume working on this changeover but without help it's going to be fairly slow.

Glad to hear you will be back btw!

If I get free time, I will try my best to give hand. Thanks.

What is the status on this issue?

It is already fixed in the next release which migrates the code to CodeIgniter 4.x. That project is still under way. You are welcome to help speed it along by helping to test or contribute code changes.

I have Mint 21.1 / Cinnamon. Can you use that?

Nope. I prefer Chili 5.1 and Paprika 2.0

Nope. I prefer Chili 5.1 and Paprika 2.0

@SteveIreland those are Linux distributions. Spices are nice too though 😂

I have Mint 21.1 / Cinnamon. Can you use that?

Any OS is fine as long as you can run the appropriate AMP stack on it.

Ok. How do i start to help?

You'll need the code on your local branch which you can get by cloning or checking out the ci4-upgrade branch. Then you need to build the code which I believe @SteveIreland placed a build.md file in the branch showing instructions. From there you need a working Apache, MySQL (or MariaDB), PHP install. With that you should be able to start testing. You can follow the pull request at #3592 and report problems through issues.

It looks like what I need to read to refresh my dev env to the latest and greatest.

It looks like what I need to read to refresh my dev env to the latest and greatest.

Yes, though I think it may be changing soon since I think @SteveIreland and @jekkos are reworking some of the old build tools in favor of gulp.

This is encouraging!! I'm working on a consignment module atm, and will try to help test the upgrade branch when I can. Very glad this epic project is still active =)

This is resolved in ci4-branch and will be released with 3.4.0. That version is PHP 7.4-8.2 compatible and 8.0-8.2 supported.