"make deploy-setup" does not abend when tools are missing

Question

"make deploy-setup" does not abend when tools are missing

dbaker-rh opened this issue 3 years ago · comments

Dave Baker commented 3 years ago

In my example cluster, I ran "make deploy-setup" with go and skopeo missing.

Errors about the missing commands showed on screen but hack/deploy-setup.sh proceeded with a broken installation.

Suggested resolution: deploy-setup.sh should verify all commands it needs are available before proceeding.

OpenShift Bot · Answer 1 · Mon Jun 14 2021 21:50:09 GMT+0800 (China Standard Time)

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

Dave Baker · Answer 2 · Mon Jun 14 2021 23:57:22 GMT+0800 (China Standard Time)

/remove-lifecycle-stale

This issue is still outstanding.

OpenShift Bot · Answer 3 · Mon Sep 13 2021 04:34:44 GMT+0800 (China Standard Time)

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

OpenShift Bot · Answer 4 · Wed Oct 13 2021 05:06:52 GMT+0800 (China Standard Time)

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

OpenShift Bot · Answer 5 · Fri Nov 12 2021 05:34:53 GMT+0800 (China Standard Time)

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci · Answer 6 · Fri Nov 12 2021 05:36:27 GMT+0800 (China Standard Time)

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.